Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove CVE-2020-8203 vulnerability in lodash.set #4704

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

andres-robinet-sw
Copy link
Contributor

Addresses #4684
#minor

Description

This PR addressess the CVE-2020-8203 vulnerability affecting [email protected] by removing the @types/nock package which depends on [email protected].
[email protected] and beyond provides its own type definitions, and @types/nock is no longer necessary.

Specific Changes

  • Removed dev dependency @types/nock in botbuilder-dialogs-adaptive-testing

Testing

The following image shows lodash.set being removed after the update:
image
The following image shows botbuilder-dialogs-adaptive-runtime tests passing:
image

@andres-robinet-sw andres-robinet-sw requested a review from a team as a code owner June 28, 2024 18:22
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9764339588

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 84.078%

Totals Coverage Status
Change from base Build 9764013148: -0.4%
Covered Lines: 20347
Relevant Lines: 22904

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9764339588

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.433%

Totals Coverage Status
Change from base Build 9764013148: 0.0%
Covered Lines: 20429
Relevant Lines: 22904

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 95a1a40 into main Jul 2, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/fix/lodash-set-vulnerability branch July 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants