Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4470] Migrate off @azure/ms-rest-js tools #4576

Merged
merged 6 commits into from
Dec 7, 2023
Merged

fix: [#4470] Migrate off @azure/ms-rest-js tools #4576

merged 6 commits into from
Dec 7, 2023

Conversation

JhontSouth
Copy link
Collaborator

Fixes #4470

Description

This PR replaces the uses of @azure/ms-rest-js in the following botbuilder-js libraries.

  • botbuilder
  • botbuilder-ai
  • botframework-connector
  • tools

Specific Changes

  • Replaced the @azure/ms-rest-js imports with @azure/core-http.
  • Added @azure/core-http to libraries package.json.
  • Updated unit tests to work with core-http RestError.

Testing

The following image shows some samples working after the update.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 4, 2023 17:16
@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7090132631

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.645%
Totals Coverage Status
Change from base Build 7049451269: 0.0%
Covered Lines: 20346
Relevant Lines: 22770
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 9074525 into main Dec 7, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/delete/ms-rest-js-tools branch December 7, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate off @azrue/ms-rest-js
3 participants
@JhontSouth @coveralls @tracyboehrer