fix: [#4568] scoreThreshold no longer works in 4.17.0 and later #4575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4568
Description
This PR reverts part of the changes in PR #4208 where the function that filtered the QnAMaker results using the score threshold value set in the QnAMaker options was removed.
It also includes a condition to skip the filter when the returned answer is the QnAMaker default answer.
Specific Changes
sortAnswersWithinThreshold
function in generateAnswerUtils.ts.Testing
These images show the results returned when a score threshold is set with a value of 0.65: