Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #4566 Teams config fetch typings #4567

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix: #4566 Teams config fetch typings #4567

merged 3 commits into from
Nov 14, 2023

Conversation

corinagum
Copy link
Collaborator

Fixes #4566

Description

My original PR had discrepancies with the C# implementation, so this is the fix

Specific Changes

  • CacheInfo added as optional to ConfigAuth
  • fix ConfigAuth response type to 'config'
  • fix BotConfigAuth type to be 'auth' only

@corinagum corinagum requested a review from a team as a code owner November 13, 2023 20:53
@corinagum corinagum changed the title Fix Teams config fetch typings Fix: #4566 Teams config fetch typings Nov 13, 2023
@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6858255824

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.635%
Totals Coverage Status
Change from base Build 6811776243: 0.0%
Covered Lines: 20336
Relevant Lines: 22760
💛 - Coveralls

@corinagum corinagum changed the title Fix: #4566 Teams config fetch typings fix: #4566 Teams config fetch typings Nov 13, 2023
@tracyboehrer tracyboehrer merged commit e0e656b into main Nov 14, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the cg/Fix-ConfigAuth branch November 14, 2023 02:13
@corinagum corinagum mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

@FBX622 FBX622 FBX622 approved these changes

@aacebo aacebo aacebo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Teams config typings
5 participants
@corinagum @coveralls @tracyboehrer @FBX622 @aacebo