Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [botframework-connector] Use HashSet instead of string array for endorsement #4526

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix: [botframework-connector] Use HashSet instead of string array for endorsement #4526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa4051
change endorsements type from array to set
crdev13 Aug 21, 2023
b3ed292
refactor: create a set with endorsements values to validate channelId
crdev13 Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions libraries/botframework-connector/src/auth/endorsementsValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ export class EndorsementsValidator {

// Does the set of endorsements match the channelId that was passed in?

// ToDo: Consider moving this to a HashSet instead of a string
// array, to make lookups O(1) instead of O(N). To give a sense
// of scope, tokens from WebChat have about 10 endorsements, and
// tokens coming from Teams have about 20.

return endorsements.some((value: string) => value === channelId);
return new Set(endorsements).has(channelId);
}
}
Loading