Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update restify Dependency in Yeoman Templates to v10.0.0 #4392

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix: Update restify Dependency in Yeoman Templates to v10.0.0 #4392

merged 2 commits into from
Jul 14, 2023

Conversation

anishprasad01
Copy link
Contributor

@anishprasad01 anishprasad01 commented Dec 19, 2022 •
edited
Loading

#minor

Description

The current version of restify in the yo template, v8.5.1, is incompatible with Node v18.x and greater. Using this version with Node v18.x can cause bots to fail to start. restify fixed this issue and released official support for Node v18 with their v10.0.0 release.

Specific Changes

Updates all three JS yo templates to specify restify v10.0.0.

Testing

  • Bots start and run successfully with this version.
  • Updating restify does not break bots on Node 16.x.

@anishprasad01 anishprasad01 requested a review from a team as a code owner December 19, 2022 18:42
@anishprasad01 anishprasad01 self-assigned this Dec 19, 2022
@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 5555512095

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.866%
Totals Coverage Status
Change from base Build 5348339402: 0.4%
Covered Lines: 20124
Relevant Lines: 22482
💛 - Coveralls

@anishprasad01 anishprasad01 mentioned this pull request Jan 4, 2023
Closed
@anishprasad01 anishprasad01 marked this pull request as draft February 8, 2023 00:08
@anishprasad01 anishprasad01 marked this pull request as ready for review February 9, 2023 22:09
@anishprasad01 anishprasad01 added the Automation: No parity PR does not need to be applied to other languages. label Feb 9, 2023
@anishprasad01 anishprasad01 marked this pull request as draft February 16, 2023 18:59
@anishprasad01 anishprasad01 marked this pull request as ready for review May 11, 2023 22:31
ceciliaavila
ceciliaavila reviewed Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anishprasad01, doesn't this change apply to TS bots?

@tracyboehrer tracyboehrer reopened this Jul 14, 2023
@tracyboehrer tracyboehrer merged commit 030bed7 into main Jul 14, 2023
12 checks passed
@tracyboehrer tracyboehrer deleted the anishprasad01/update-js-yo-generators-restify branch July 14, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliaavila ceciliaavila ceciliaavila left review comments

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

@anishprasad01 anishprasad01

Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anishprasad01 @coveralls @tracyboehrer @ceciliaavila