Fix issues in botbuilder-stdlib (#4814)

microsoft · Jan 6, 2025 · df3b3f5 · df3b3f5
1 parent 551267e
commit df3b3f5
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 20 deletions.
diff --git a/libraries/botbuilder-stdlib/eslint.config.cjs b/libraries/botbuilder-stdlib/eslint.config.cjs
diff --git a/libraries/botbuilder-stdlib/package.json b/libraries/botbuilder-stdlib/package.json
@@ -9,9 +9,6 @@
   "bugs": {
     "url": "https://github.com/Microsoft/botbuilder-js/issues"
   },
-  "dependencies": {
-    "eslint-plugin-only-warn": "^1.1.0"
-  },
   "repository": {
     "type": "git",
     "url": "https://github.com/Microsoft/botbuilder-js.git"
@@ -20,7 +17,7 @@
     "build": "tsc -b",
     "clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
     "depcheck": "depcheck --config ../../.depcheckrc",
-    "lint": "eslint .",
+    "lint": "eslint . --config ../../eslint.config.cjs",
     "postbuild": "downlevel-dts lib _ts3.4/lib",
     "test": "yarn build && nyc mocha --check-leaks tests"
   },

diff --git a/libraries/botbuilder-stdlib/src/retry.ts b/libraries/botbuilder-stdlib/src/retry.ts
@@ -12,7 +12,7 @@
 export async function retry<T>(
     promise: (n: number) => Promise<T>,
     maxRetries: number,
-    initialDelay = 500
+    initialDelay = 500,
 ): Promise<T | undefined> {
     let delay = initialDelay,
         n = 1,

diff --git a/libraries/botbuilder-stdlib/src/stringify.ts b/libraries/botbuilder-stdlib/src/stringify.ts
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 /**
  * Encapsulates JSON.stringify function to detect and handle different types of errors (eg. Circular Structure).
  *
@@ -64,7 +62,7 @@ export function stringify(value: any, replacer?: (key: string, value: any) => an
                 const value = stringifyReplacer(replacer)(key, val);
                 return value;
             },
-            space
+            space,
         );
     }
 }

diff --git a/libraries/botbuilder-stdlib/src/types.ts b/libraries/botbuilder-stdlib/src/types.ts
@@ -11,4 +11,4 @@ export type Maybe<T> = T | Nil;
 export type Newable<T, A extends unknown[] = unknown[]> = new (...args: A) => T;
 
 // Extends<T> mimics Newable<T>, but works for abstract classes as well
-export type Extends<T> = Function & { prototype: T }; // eslint-disable-line @typescript-eslint/ban-types
+export type Extends<T> = Function & { prototype: T }; // eslint-disable-line @typescript-eslint/no-unsafe-function-type
diff --git a/libraries/botbuilder-stdlib/tests/delay.test.js b/libraries/botbuilder-stdlib/tests/delay.test.js
@@ -7,6 +7,7 @@ const { delay } = require('../');
 
 describe('delay', function () {
     let sandbox;
+
     beforeEach(function () {
         sandbox = sinon.createSandbox({ useFakeTimers: true });
     });

diff --git a/libraries/botbuilder-stdlib/tests/stringify.test.js b/libraries/botbuilder-stdlib/tests/stringify.test.js
@@ -99,7 +99,7 @@ describe('stringify', function () {
             const withoutReplacerToJSON = stringify(value);
 
             const assertWithReplacerToJSON = JSON.stringify(
-                _replacer.call(JSON.parse(JSON.stringify(value, replacer)))
+                _replacer.call(JSON.parse(JSON.stringify(value, replacer))),
             );
             assert.ok(withReplacerToJSON.includes('"_id":":toJSON:replacer:_replacer"'));
             assert.strictEqual(withReplacerToJSON, assertWithReplacerToJSON);