Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fixes for CVE-2022-43552, CVE-2023-27536, CVE-2023-27535, CVE-2023-27538, CVE-2023-23916 and CVE-2023-46218 #11043

Open
wants to merge 12 commits into
base: fasttrack/2.0
Choose a base branch
from

Conversation

sharath-srikanth-chellappa
Copy link
Contributor

@sharath-srikanth-chellappa sharath-srikanth-chellappa commented Nov 13, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Patches for CVE-2022-43552, CVE-2023-27536, CVE-2023-27535, CVE-2023-27538, CVE-2023-23916 and CVE-2023-46218

Based on upstream fixes:

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

Copy link
Member

@anphel31 anphel31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update the toolchain manifests with the new cmake revision?

@anphel31
Copy link
Member

It looks like we have another PR which upgrades cmake and supercedes these patches.
#11037

@sharath-srikanth-chellappa
Copy link
Contributor Author

sharath-srikanth-chellappa commented Nov 13, 2024

can you please update the toolchain manifests with the new cmake revision?

Have updated the toolkits for arm64 and amd64

It looks like we have another PR which upgrades cmake and supercedes these patches. #11037

Have gone ahead and closed this PR which I created.

@anphel31 Can you please take a look

@anphel31
Copy link
Member

@sharath-srikanth-chellappa , the closed PR #11037 contains fixes for many other CVES. Do you plan to include those in this PR?

@sharath-srikanth-chellappa
Copy link
Contributor Author

sharath-srikanth-chellappa commented Nov 13, 2024

@sharath-srikanth-chellappa , the closed PR #11037 contains fixes for many other CVES. Do you plan to include those in this PR?

@anphel31
No I don't plan to. There are many new patches that have been introduced by other CVEs which make the direct upgrade of the package version much harder. The cmake package building itself fails in the case that I do such a major version upgrade. This is the reason why I closed out the initial approach (of upgrading the cmake package version) and upgrading individual CVEs assigned.

@sharath-srikanth-chellappa sharath-srikanth-chellappa force-pushed the sharathsr/fasttrack/2.0/CVE-2023-27536-CVE-2022-43552 branch from 44a05a9 to c27c129 Compare November 15, 2024 01:03
@sharath-srikanth-chellappa sharath-srikanth-chellappa marked this pull request as draft November 15, 2024 01:07
@sharath-srikanth-chellappa sharath-srikanth-chellappa changed the title cmake: Fixes for CVE-2023-27536 and CVE-2022-43552 cmake: Fixes for CVE-2022-43552, CVE-2023-27536, CVE-2023-27535, CVE-2023-27538, CVE-2023-23916, CVE-2023-46218 and CVE-2023-23915 Nov 15, 2024
@sharath-srikanth-chellappa sharath-srikanth-chellappa changed the title cmake: Fixes for CVE-2022-43552, CVE-2023-27536, CVE-2023-27535, CVE-2023-27538, CVE-2023-23916, CVE-2023-46218 and CVE-2023-23915 cmake: Fixes for CVE-2022-43552, CVE-2023-27536, CVE-2023-27535, CVE-2023-27538, CVE-2023-23916 and CVE-2023-46218 Nov 15, 2024
@sharath-srikanth-chellappa sharath-srikanth-chellappa marked this pull request as ready for review November 15, 2024 20:29
@sharath-srikanth-chellappa
Copy link
Contributor Author

@anphel31 @jslobodzian - I have gone ahead and added multiple CVEs to the same PR. Can you please take a look and reapprove so that I can merge it. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants