Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not webpack kerberos #6790

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Do not webpack kerberos #6790

merged 1 commit into from
Aug 17, 2019

Conversation

anthonydresser
Copy link
Contributor

Modules depending on node-bindings can't be webpacked. TooTallNate/node-bindings#43

kevcunnane
kevcunnane approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@kevcunnane kevcunnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this so quickly Anthony! Really appreciate you helping get this fixed.

@anthonydresser anthonydresser merged commit 6f037ce into master Aug 17, 2019
@anthonydresser anthonydresser deleted the bug/fixkerberos branch August 17, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevcunnane kevcunnane kevcunnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydresser @kevcunnane