Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying non-default columns for local .xel files #25907

Merged

Conversation

glaubercini
Copy link
Contributor

@glaubercini glaubercini commented Sep 11, 2024

A .xel file produced outside of SQL Server may contain a different set of columns. Since Azure Data Studio's SQL Server Profiler has its own set of display columns, these non-default ones are simply ignored.

This PR adds support for displaying non-default columns in the details section while preserving the default behavior that fixes #25906 issue.

Before:
before

After:
after

@SakshiS-harma
Copy link
Contributor

Hey @glaubercini, it was great working with you for this bug+fix.
Do you mind adding a snippet of before (how the data wasn't visible on UI in ADS, but it was presented in SSMS) and after (data presented in ADS as well)?
Changes look good to me :shipit: .
May be just wait for another reviewer to approve before merging your changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10818236217

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 41.721%

Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
Totals Coverage Status
Change from base Build 10777409214: -0.003%
Covered Lines: 30728
Relevant Lines: 68921

💛 - Coveralls

@SakshiS-harma SakshiS-harma merged commit 2401c59 into microsoft:main Sep 12, 2024
11 checks passed
@glaubercini glaubercini deleted the dev/glaubercini/xel_columns branch September 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-default fields in .xel files are not displayed
4 participants