Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up query results copying #25866

Merged
merged 11 commits into from
Sep 13, 2024
Merged

Speed up query results copying #25866

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4fe1077
Conditionally copy query results in backend
lewis-sanchez Aug 21, 2024
9aaaa5b
Remote dep on remote hosts
lewis-sanchez Aug 27, 2024
f453469
Remove changes
lewis-sanchez Aug 28, 2024
2fbca7c
Remove changes that caused slowdown
lewis-sanchez Aug 28, 2024
86d9849
Prefer copying from UI process
lewis-sanchez Aug 29, 2024
8d33982
Revert "Prefer copying from UI process"
lewis-sanchez Aug 30, 2024
550d24e
Set prefer provider copy setting to false for linux
lewis-sanchez Aug 30, 2024
177aff6
Revert "Set prefer provider copy setting to false for linux"
lewis-sanchez Aug 30, 2024
34df6d7
Default copy handling to UI for Linux
lewis-sanchez Sep 5, 2024
7a6b98d
Bump SqlOps-DataProtocolClient package to 2.0.1
lewis-sanchez Sep 12, 2024
c5bc7ae
Bump STS Version to 5.0.20240912.2
lewis-sanchez Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sql/azdata.proposed.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,10 @@ declare module 'azdata' {
* The selected ranges to be copied.
*/
selections: SelectionRange[];
/**
* Whether to copy results from the UI process.
*/
copyFromUIProcess?: boolean;
lewis-sanchez marked this conversation as resolved.
Show resolved Hide resolved
}

export interface CopyResultsRequestResult {
Expand Down
8 changes: 5 additions & 3 deletions src/sql/workbench/services/query/common/queryRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,10 +618,12 @@ export class QueryGridDataProvider implements IGridDataProvider {
private async handleCopyRequestByProvider(selections: Slick.Range[], includeHeaders?: boolean): Promise<void> {
executeCopyWithNotification(this._notificationService, this._configurationService, selections, async () => {
let results = await this.queryRunner.copyResults(selections, this.batchId, this.resultSetId, this.shouldIncludeHeaders(includeHeaders));
let clipboardData: ClipboardData = {
text: results.results
if (results.results) {
let clipboardData: ClipboardData = {
text: results.results
}
this._clipboardService.write(clipboardData);
}
this._clipboardService.write(clipboardData);
});
}

Expand Down