Using User Delegation Key to upload ARM templates #25600
+266
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahuroshan
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
Pull Request Test Coverage Report for Build 8783588636Details
💛 - Coveralls |
sahuroshan
changed the title
|
@sahuroshan are you still working on this PR or should we close it out as abandoned? |
Hi @kburtram , We had paused because of security push, we will start this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use SAS tokens to upload ARM templates to storage accounts . SAS tokens needs to be signed with either storage account key or user delegation key . Earlier we were using account key , but with recent security push use of account keys is discouraged. This PR contains the change for using user delegation key instead of account keys.
ADO task - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3119155
Reference code - https://github.com/Azure-Samples/AzureStorageSnippets/blob/master/blobs/howto/JavaScript/NodeJS-v12/dev-guide/upload-blob-from-blob-sas-token.js
https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#understand-how-disallowing-shared-key-affects-sas-tokens
https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview