Check for #224 regression

[jamesmyatt]

I don't think that #224 is resolved. This should prove it.

[winstliu]

Looks like tests are passing, @jamesmyatt. Can you explain more why you think there's been a regression?

[jamesmyatt]

Using this schema with check-jsonschema fails to validate in cases where the boolean is stored as a literal boolean rather than a string recognised as boolean. For example: python-jsonschema/check-jsonschema#237

Looking at the Azure DevOps documents, they recommend using boolean true, rather than string "true": e.g. https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/trigger?view=azure-pipelines#trigger-batch-branches-paths-tags

However the schema doesn't allow this (See https://github.com/microsoft/azure-pipelines-vscode/blob/main/service-schema.json#L4008) which is the same issue issue as #224 , which was closed as fixed.

I thought it would be worth updating the test cases to include something that validates against #/definitions/boolean, and I naively made a change that I thought would show this.

Fundamentally, either the schema is wrong or the documentation is wrong, since the schema says no literal booleans and the documentation says they're OK. Furthermore, the validator should fail for this change, which means that either the file isn't checked in the CI tests or the validator used here is non-compliant with the JSON Schema specification (as I understand it: I may also not understand the specification correctly).

What's the best way to proceed with this? As I understand it, the schema is automatically generated, but I don't know where from. And this (or something like it) is a recurring issue:

• Schema validation: continueOnError should be boolean #507
• Schema type for persistCredentials should be boolean, not string #505
• 'continueOnError' parameter only accepts boolean literals #493
• "definitions/boolean" in schema does not allow for boolean values, resulting in failing validation for a step with continueOnError: true #446
• Yaml schema persistCredentials should be validated as a boolean #366
• Extension gives invalid problem: Incorrect type. Expected "boolean" when a boolean parameter is used #360
• checkout.lfs is string in ref schema while documentation states boolean #240
• fix: #/definitions/boolean by adding type boolean #238