-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(axe-core-4.6): Update axe-core to 4.6.3 (#918)
#### Details This PR updates the repo to use axe-core 4.6.3 <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation We are updating Accessibility Insights products to use axe-core 4.6.3 <!-- This can be as simple as "addresses issue #123" --> ##### Context The first few commits represent the update to axe-core 4.6.3 and updating the main tests for the repo. The last part of the PR (handled by @shanisebarona) will update the wcag-link-data.test to account for the fact that axe-core 4.6.3 references one success criterion from WCAG 2.2. <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> Yes. We considered updating the converter files and related wcag-link components to account for two WCAG versions, but this proved more complicated than what seemed reasonable based on the amount of support it would provide to users. Instead, we've opted to not reference the 1 WCAG 2.2 criterion. #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [X] PR title respects [Conventional Commits](https://www.conventionalcommits.org) (starts with `fix:`, `feat:`, etc, and is suitable for user-facing release notes) - [X] PR contains no breaking changes, **OR** description of both PR **and final merge commit** starts with `BREAKING CHANGE:` - [N/A ] (if applicable) Addresses issue: #0000 - [X] Added relevant unit tests for your changes - [ ] Ran `yarn precheckin` - [ ] Verified code coverage for the changes made --------- Co-authored-by: SB <[email protected]>
- Loading branch information
1 parent
f2f5628
commit 451e891
Showing
18 changed files
with
107,572 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| [ | ||
| { | ||
| "testEngine": { | ||
| "name": "axe-core", | ||
| "version": "4.6.3" | ||
| }, | ||
| "testRunner": { | ||
| "name": "axe" | ||
| }, | ||
| "testEnvironment": { | ||
| "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/109.0.5414.120 Safari/537.36", | ||
| "windowWidth": 800, | ||
| "windowHeight": 600, | ||
| "orientationAngle": 0, | ||
| "orientationType": "landscape-primary" | ||
| }, | ||
| "timestamp": "2023-02-07T17:56:33.760Z", | ||
| "url": "file:///C:/Users/jagibson/repos/axe-sarif-converter/src/test-resources/basic.html", | ||
| "toolOptions": { | ||
| "runOnly": { | ||
| "type": "rule", | ||
| "values": [ | ||
| "document-title" | ||
| ] | ||
| }, | ||
| "reporter": "v1" | ||
| }, | ||
| "inapplicable": [], | ||
| "passes": [], | ||
| "incomplete": [], | ||
| "violations": [ | ||
| { | ||
| "id": "document-title", | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.text-alternatives", | ||
| "wcag2a", | ||
| "wcag242", | ||
| "ACT" | ||
| ], | ||
| "description": "Ensures each HTML document contains a non-empty <title> element", | ||
| "help": "Documents must have <title> element to aid in navigation", | ||
| "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/document-title?application=webdriverjs", | ||
| "nodes": [ | ||
| { | ||
| "any": [ | ||
| { | ||
| "id": "doc-has-title", | ||
| "data": null, | ||
| "relatedNodes": [], | ||
| "impact": "serious", | ||
| "message": "Document does not have a non-empty <title> element" | ||
| } | ||
| ], | ||
| "all": [], | ||
| "none": [], | ||
| "impact": "serious", | ||
| "html": "<html class=\"deque-axe-is-ready\"><head></head><body>\n</body><script>document.documentElement.classList.add(\"deque-axe-is-ready\");</script></html>", | ||
| "target": [ | ||
| "html" | ||
| ], | ||
| "failureSummary": "Fix any of the following:\n Document does not have a non-empty <title> element" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| [ | ||
| { | ||
| "id": "document-title", | ||
| "result": "failed", | ||
| "pageLevel": false, | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.text-alternatives", | ||
| "wcag2a", | ||
| "wcag242", | ||
| "ACT" | ||
| ], | ||
| "description": "Ensures each HTML document contains a non-empty <title> element", | ||
| "help": "Documents must have <title> element to aid in navigation", | ||
| "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/document-title?application=axe-puppeteer", | ||
| "inapplicable": [], | ||
| "passes": [], | ||
| "incomplete": [], | ||
| "violations": [ | ||
| { | ||
| "node": { | ||
| "selector": [ | ||
| "html" | ||
| ], | ||
| "source": "<html><head></head><body>\n</body></html>", | ||
| "xpath": [ | ||
| "/html" | ||
| ], | ||
| "ancestry": [ | ||
| "html" | ||
| ], | ||
| "nodeIndexes": [ | ||
| 0 | ||
| ] | ||
| }, | ||
| "any": [ | ||
| { | ||
| "id": "doc-has-title", | ||
| "data": null, | ||
| "relatedNodes": [], | ||
| "impact": "serious", | ||
| "message": "Document does not have a non-empty <title> element" | ||
| } | ||
| ], | ||
| "all": [], | ||
| "none": [], | ||
| "impact": "serious", | ||
| "result": "failed" | ||
| } | ||
| ] | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| { | ||
| "testEngine": { | ||
| "name": "axe-core", | ||
| "version": "4.6.3" | ||
| }, | ||
| "testRunner": { | ||
| "name": "axe" | ||
| }, | ||
| "testEnvironment": { | ||
| "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/101.0.4950.0 Safari/537.36", | ||
| "windowWidth": 800, | ||
| "windowHeight": 600, | ||
| "orientationAngle": 0, | ||
| "orientationType": "portrait-primary" | ||
| }, | ||
| "timestamp": "2000-01-02T03:04:05.006Z", | ||
| "url": "http://localhost/", | ||
| "toolOptions": { | ||
| "xpath": true, | ||
| "runOnly": { | ||
| "type": "rule", | ||
| "values": [ | ||
| "document-title" | ||
| ] | ||
| }, | ||
| "reporter": "v1" | ||
| }, | ||
| "inapplicable": [], | ||
| "passes": [], | ||
| "incomplete": [], | ||
| "violations": [ | ||
| { | ||
| "id": "document-title", | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.text-alternatives", | ||
| "wcag2a", | ||
| "wcag242", | ||
| "ACT" | ||
| ], | ||
| "description": "Ensures each HTML document contains a non-empty <title> element", | ||
| "help": "Documents must have <title> element to aid in navigation", | ||
| "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/document-title?application=axe-puppeteer", | ||
| "nodes": [ | ||
| { | ||
| "any": [ | ||
| { | ||
| "id": "doc-has-title", | ||
| "data": null, | ||
| "relatedNodes": [], | ||
| "impact": "serious", | ||
| "message": "Document does not have a non-empty <title> element" | ||
| } | ||
| ], | ||
| "all": [], | ||
| "none": [], | ||
| "impact": "serious", | ||
| "html": "<html><head></head><body>\n</body></html>", | ||
| "target": [ | ||
| "html" | ||
| ], | ||
| "xpath": [ | ||
| "/html" | ||
| ], | ||
| "failureSummary": "Fix any of the following:\n Document does not have a non-empty <title> element" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| { | ||
| "testEngine": { | ||
| "name": "axe-core", | ||
| "version": "4.6.3" | ||
| }, | ||
| "testRunner": { | ||
| "name": "axe" | ||
| }, | ||
| "testEnvironment": { | ||
| "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/101.0.4950.0 Safari/537.36", | ||
| "windowWidth": 800, | ||
| "windowHeight": 600, | ||
| "orientationAngle": 0, | ||
| "orientationType": "portrait-primary" | ||
| }, | ||
| "timestamp": "2000-01-02T03:04:05.006Z", | ||
| "url": "http://localhost/", | ||
| "toolOptions": { | ||
| "xpath": true, | ||
| "runOnly": { | ||
| "type": "rule", | ||
| "values": [ | ||
| "document-title" | ||
| ] | ||
| }, | ||
| "reporter": "v2" | ||
| }, | ||
| "inapplicable": [], | ||
| "passes": [], | ||
| "incomplete": [], | ||
| "violations": [ | ||
| { | ||
| "id": "document-title", | ||
| "impact": "serious", | ||
| "tags": [ | ||
| "cat.text-alternatives", | ||
| "wcag2a", | ||
| "wcag242", | ||
| "ACT" | ||
| ], | ||
| "description": "Ensures each HTML document contains a non-empty <title> element", | ||
| "help": "Documents must have <title> element to aid in navigation", | ||
| "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/document-title?application=axe-puppeteer", | ||
| "nodes": [ | ||
| { | ||
| "any": [ | ||
| { | ||
| "id": "doc-has-title", | ||
| "data": null, | ||
| "relatedNodes": [], | ||
| "impact": "serious", | ||
| "message": "Document does not have a non-empty <title> element" | ||
| } | ||
| ], | ||
| "all": [], | ||
| "none": [], | ||
| "impact": "serious", | ||
| "html": "<html><head></head><body>\n</body></html>", | ||
| "target": [ | ||
| "html" | ||
| ], | ||
| "xpath": [ | ||
| "/html" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.