Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Convert autogenstudio to new serializable config language #5200

Closed

Conversation

EItanya
Copy link

@EItanya EItanya commented Jan 25, 2025

@victordibia and @ekzhu and @jackgerrits as reviewers?

Why are these changes needed?

This is a draft PR to begin the server side work of migrating autogen-studio over to the new serializable config style.

Related issue number

#5172

Checks

@EItanya EItanya changed the title initial commit new component style for autogen UI [DRAFT] Convert autogenstudio to new serializable config language Jan 25, 2025
@victordibia
Copy link
Collaborator

Hi @EItanya ,
Thanks for starting this. I love the excitement, thanks for sharing!

There are a few thoughts here

  • Does component config still serve a role or most modules should use the load_component modules durectly e.g., teammanager etc
  • Similarly, logic in config component needs to be updated (entity linking, current checks for component type should be based on the component itself)
  • Overall, the backend refactor needs to be synced with the frontend (UI elements must work with the updated config structure)

These are deep reaching changes and probably should all land in unison.
I will keep this open for now (many good ideas), but will likely create a separate branch (and then PR) where we can both collaborate on all of the above. ETA? monday/tuesday.

As discussed on the other thread, can you help with shepherding the other MCP Httptools PR, getting it merged ? That would be a huge help if we can already test these things robustly in python code first, write documentation before we hammer out studio plumbing?

@EItanya
Copy link
Author

EItanya commented Jan 25, 2025

Hey, thanks for the quick response, I think it's worth explaining a bit of my motivation here.

I know this will not be the actual final PR for this feature, I'm lacking a ton of context on the project overall, not to mention I am not a very good UI engineer 😆.

I am going to be going on vacation starting Tuesday and this functionality is more to unblock some of my colleagues and prove out some things to myself, rather than anything official. I decided to share it in case it is of any use to you in starting out as it does seem to work. I am working on a project which is hoping to leverage the backend for autogen-studio specifically, not the UI for now, so this allows my colleagues to begin more testing in earnest despite not being fully ready.

In terms of the specific feedback:

  • I agree that component config should probably be replaced completely by ComponentModel, as mentioned this was just a way to get the code code running
  • I haven't looked too much into the db code yet, but I agree with you. I started testing with the serve endpoint rather than the full backend so it's very likely that code doesn't work, or at the very least is non-optimal. Not to mention there's the question of DB schema/ugrades.
  • Agreed on UI, as mentioned I didn't begin on that for selfish reasons, but I was a typescript engineer in a past life so who knows 😆

@victordibia
Copy link
Collaborator

Ah .. got it.
I suspected that you were making progress for multiple reasons .. and its great to see! Thank you!!
I think the ideas you have here will shape the rest of the work!
If you dont mind, we could even use this branch directly.
I'll share more later today or tomorrow (currently on the road!)

@EItanya
Copy link
Author

EItanya commented Jan 25, 2025

Sounds good to me, no rush!

Definitely feel free to use this branch

@raimondasl raimondasl added the proj-studio Related to AutoGen Studio. label Jan 26, 2025
@victordibia
Copy link
Collaborator

This is the branch where I am tracking work on updating the backend. (lots of similarity to what you have here) and UI. UI piece still needs a bit of work. Will update here again when it is ready in some form.
https://github.com/microsoft/autogen/tree/ags_declarative_vd

@EItanya
Copy link
Author

EItanya commented Jan 27, 2025

If you aren't actively using this branch should I close the PR for clarity?

@victordibia
Copy link
Collaborator

Yes, we can close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-studio Related to AutoGen Studio.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants