Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionTool partial support #5183

Merged

Conversation

nour-bouzid
Copy link
Contributor

Why are these changes needed?

FunctionTool supports passing in a partial

Related issue number

Closes #5151

Checks

@nour-bouzid nour-bouzid changed the title Update function_tool to support partials + tests FunctionTool partial support Jan 24, 2025
@jackgerrits jackgerrits requested review from jackgerrits and ekzhu and removed request for jackgerrits January 24, 2025 16:55
@nour-bouzid
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@nour-bouzid nour-bouzid force-pushed the feature/functiontool_support_partial branch from db96a08 to 2c879c2 Compare January 26, 2025 23:05
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (2f1684b) to head (26b3dd7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5183   +/-   ##
=======================================
  Coverage   70.40%   70.40%           
=======================================
  Files         179      179           
  Lines       11615    11617    +2     
=======================================
+ Hits         8177     8179    +2     
  Misses       3438     3438           
Flag Coverage Δ
unittests 70.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nour-bouzid nour-bouzid force-pushed the feature/functiontool_support_partial branch from e20fb98 to 8d4724b Compare January 27, 2025 13:49
@jackgerrits jackgerrits enabled auto-merge (squash) January 29, 2025 14:15
@jackgerrits jackgerrits merged commit 02e968a into microsoft:main Jan 29, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunctionTool should support passing in a partial
3 participants