-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FunctionTool partial support #5183
Merged
jackgerrits
merged 5 commits into
microsoft:main
from
nour-bouzid:feature/functiontool_support_partial
Jan 29, 2025
Merged
FunctionTool partial support #5183
jackgerrits
merged 5 commits into
microsoft:main
from
nour-bouzid:feature/functiontool_support_partial
Jan 29, 2025
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nour-bouzid
changed the title
Update function_tool to support partials + tests
FunctionTool partial support
Jan 24, 2025
jackgerrits
requested review from
jackgerrits and
ekzhu
and removed request for
jackgerrits
January 24, 2025 16:55
@microsoft-github-policy-service agree company="Microsoft" |
jackgerrits
requested changes
Jan 24, 2025
python/packages/autogen-core/src/autogen_core/tools/_function_tool.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-core/src/autogen_core/_function_utils.py
Outdated
Show resolved
Hide resolved
nour-bouzid
force-pushed
the
feature/functiontool_support_partial
branch
from
January 26, 2025 23:05
db96a08
to
2c879c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5183 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 179 179
Lines 11615 11617 +2
=======================================
+ Hits 8177 8179 +2
Misses 3438 3438
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nour-bouzid
force-pushed
the
feature/functiontool_support_partial
branch
from
January 27, 2025 13:49
e20fb98
to
8d4724b
Compare
ekzhu
approved these changes
Jan 27, 2025
jackgerrits
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FunctionTool supports passing in a partial
Related issue number
Closes #5151
Checks