Fixed KeyTrigger where the Alt key was being seen as Key.System #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgoertz-msft Looks like we have some build errors I do not have access to fix Error: System.IO.FileLoadException: Could not load file or assembly 'Microsoft.Xaml.Behaviors, Version=1.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) |
|
@jstedfast Could you please help Brian with this? Thank you! |
mgoertz-msft
approved these changes
Aug 24, 2024
jstedfast
force-pushed
the
alt-keytrigger-fix
branch
from
fd48e9c
to
be57774
Compare
ChrisPulman
referenced
this pull request
in reactiveui/ReactiveUI
Sep 19, 2024
#3903) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.Xaml.Behaviors.Wpf](https://redirect.github.com/Microsoft/XamlBehaviorsWpf) ([source](https://redirect.github.com/microsoft/XamlBehaviorsWpf)) | `1.1.122` -> `1.1.135` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/XamlBehaviorsWpf (Microsoft.Xaml.Behaviors.Wpf)</summary> ### [`v1.1.135`](https://redirect.github.com/microsoft/XamlBehaviorsWpf/releases/tag/v1.1.135): Behaviors 1.1.135 ##### What's Changed This release fixes an issue with [Keytriggers not firing when the ALT modifier is used](https://redirect.github.com/microsoft/XamlBehaviorsWpf/issues/175): - Fixed KeyTrigger where the Alt key was being seen as Key.System by [@​brianlagunas](https://redirect.github.com/brianlagunas) in [https://github.com/microsoft/XamlBehaviorsWpf/pull/176](https://redirect.github.com/microsoft/XamlBehaviorsWpf/pull/176) **Full Changelog**: microsoft/XamlBehaviorsWpf@v1.1.122...v1.1.135 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiRGVwZW5kZW5jeSBNYW5hZ2VtZW50Il19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
There are not unit tests because WPF makes it impossible to simulate modifier keys in a unit test.