Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in other queries caused by changing fail_driver1.c #97

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

jacob-ronstadt
Copy link
Contributor

Checklist for Pull Requests

Fix issues in other queries caused by changing fail_driver1.c

  • Description is filled out.
  • Only one query or related query group is in this pull request.
  • The version number on changed queries has been increased via the @version comment in the file header.
  • All unit tests have been run: (Test README.md).
  • Commands codeql database create and codeql database analyze have completed successfully.
  • A .qhelp file has been added for any new queries or updated if changes have been made to an existing query.

NateD-MSFT and others added 9 commits November 21, 2023 15:28
RI of development branch to main (11/21/23).
…driver_snippet.c to be the first include in fail_driver1.c so that ntifs.h could be included in driver_snippet.c without errors
…allow different project configurations for different tests. Revert fail_driver1.c to fix build issues caused by previous change
Copy link
Contributor

@NateD-MSFT NateD-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can take a minute to check if there's a way to pass in definitions on the MSBuild line beyond creating a whole new configuration for the project, I would appreciate it. Adding another configuration outside of Debug and Release feels heavy-handed to me to just get a single #define set up correctly, but maybe this really is the only way.

@jacob-ronstadt
Copy link
Contributor Author

@NateD-MSFT I looked into this some more and there doesn't seem to be an easy way to just pass a preprocessor definition from msbuild to the compiler (/D flag for cl.exe). A slight workaround is to add a preprocessor definition to the C/C++ properties of the VS project in the form NAME=$(PropertyName). "NAME" can then be used in the code for conditional compilation and msbuild can be called with an added property of /p:NAME=value. This would be easier to expand to add new definitions than having multiple configurations. It would only require adding a new preprocessor name/value pair to the project properties.

@jacob-ronstadt jacob-ronstadt merged commit 12bf2c9 into development Dec 8, 2023
2 checks passed
@jacob-ronstadt jacob-ronstadt deleted the jacob-ronstadt/unicode_string branch December 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants