-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues in other queries caused by changing fail_driver1.c #97
Conversation
RI of development branch to main (11/21/23).
…driver_snippet.c to be the first include in fail_driver1.c so that ntifs.h could be included in driver_snippet.c without errors
…allow different project configurations for different tests. Revert fail_driver1.c to fix build issues caused by previous change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can take a minute to check if there's a way to pass in definitions on the MSBuild line beyond creating a whole new configuration for the project, I would appreciate it. Adding another configuration outside of Debug and Release feels heavy-handed to me to just get a single #define set up correctly, but maybe this really is the only way.
…finition project property instead.
@NateD-MSFT I looked into this some more and there doesn't seem to be an easy way to just pass a preprocessor definition from msbuild to the compiler (/D flag for cl.exe). A slight workaround is to add a preprocessor definition to the C/C++ properties of the VS project in the form NAME=$(PropertyName). "NAME" can then be used in the code for conditional compilation and msbuild can be called with an added property of /p:NAME=value. This would be easier to expand to add new definitions than having multiple configurations. It would only require adding a new preprocessor name/value pair to the project properties. |
Checklist for Pull Requests
Fix issues in other queries caused by changing fail_driver1.c
@version
comment in the file header.codeql database create
andcodeql database analyze
have completed successfully.