-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local build and tests for UWP #980
Open
benstevens48
wants to merge
23
commits into
microsoft:uwp/main
Choose a base branch
from
Pictureflect:fix-build
base: uwp/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struggling to get a local build and tests working for UWP. Some of this may have been due to my NuGet being out of data, but in any case, relaying on packages with vulnerabilities and private repositories (presumably as a workaround for that) is not great, even if just for the tests, so I made some changes to get the build and tests working without this.
Warning: this changes the min Windows version to Windows 10 build 16299 (aka 1709). Not sure if you can accept this change or not.
A summary of changes
Please ignore the individual commits since I went back and forth several times due to issues like the build randomly switching between generating appx and appxbundle.
As a result of the changes, the tests all pass and there are 5 warnings. 3 warnings that say "warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/OPT:ICF' specification" which I don't really want to touch since I don't have a good knowledge of C++ build args and this is from the main project. Then 2 warnings regarding the projection being experimental.