Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Microsoft.Wpf.Interop.DirectX_dxsdk.sln #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Microsoft.Wpf.Interop.DirectX_dxsdk.sln #29

wants to merge 1 commit into from

Conversation

xmedeko
Copy link

@xmedeko xmedeko commented Nov 9, 2016

Fixing build of Microsoft.Wpf.Interop.DirectX_dxsdk.sln

@msftclas
Copy link

msftclas commented Nov 9, 2016

Hi @xmedeko, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@weltkante
Copy link

You are referencing the wrong project.

I think Microsoft.Wpf.Interop.DirectX_dxsdk.sln should be referencing Microsoft.Wpf.Interop.DirectX_dxsdk.vcxproj

and not Microsoft.Wpf.Interop.DirectX_winsdk.vcxproj like you did

For that we already got Microsoft.Wpf.Interop.DirectX_winsdk.sln

@@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.23107.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Wpf.Interop.DirectX_dxsdk", "Microsoft.Wpf.Interop.DirectX\Microsoft.Wpf.Interop.DirectX.csproj", "{51880B2F-A2DD-4669-B7F2-D5315B03C06D}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Wpf.Interop.DirectX_dxsdk", "Microsoft.Wpf.Interop.DirectX\Microsoft.Wpf.Interop.DirectX_winsdk.vcxproj", "{51880B2F-A2DD-4669-B7F2-D5315B03C06D}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong project file here, should be using the dxsdk version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will fix that by rebase.

@msftclas
Copy link

msftclas commented Nov 9, 2016

@xmedeko, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants