Add notification functionality from WinAppSDK #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Kumar Singh <[email protected]>
JesseCol
reviewed
Apr 29, 2024
| @@ -2,10 +2,13 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>WinExe</OutputType> | |||
| <TargetFramework>net9.0-windows</TargetFramework> | |||
| <TargetFramework>net9.0-windows10.0.19041.0</TargetFramework> | |||
There was a problem hiding this comment.
FYI, we're bringing a fix to WinAppSDK 1.5 that should make this change unnecessary, it may be released this week. Once it's ready, let's use it and see if we can change this back to "net9.0-windows", etc.
There was a problem hiding this comment.
I tried this out locally, it looks like we'll need to keep this like you have it for now :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notification functionality from WinAppSDK
Microsoft Reviewers: Open in CodeFlow