Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (csrc): Restructure C++ code organization to facilitate adding new kernels #169

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

lcy-seso
Copy link
Contributor

@lcy-seso lcy-seso commented Jan 20, 2025

This PR does not change any logic or functionality in the main branch. It restructures the existing C++ code organization to facilitate the addition of new kernels in subsequent PRs.

In general, each customized CUDA kernel involves modifying the following three files at the backend:

  1. Registering Python bindings and adding declarations in ops.cc.
  2. Placing the host's kernel launch function in x.cc, where x is the operator's name.
  3. Implementing CUDA kernels in x.cuh.

@haruhi55 haruhi55 requested a review from YangWang92 January 20, 2025 12:44
@haruhi55 haruhi55 merged commit 676964f into microsoft:main Jan 20, 2025
7 checks passed
@lcy-seso lcy-seso deleted the restructure branch January 20, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants