Allow extends type to be supertype of constraint types when narrowing conditional return type #61117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would not attempt to do return type narrowing for the following conditional type:
The reason was that the extends type
{}
was not identical to any element of the parameter union constraint type{ a: string } | undefined
.This PR lifts the restriction, only requiring that a conditional's extends type be a supertype of an element of the parameter union constraint type. So now TS will attempt return type narrowing for the above example.
Note that just like the user is responsible for making sure the union components of the parameter type are disjoint types, the extends types in the conditional type also should be disjoint, or bad things can happen (see second example in the new test).