Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Debug.checkDefined to avoid redundant debugger stops #60009

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Andarist
Copy link
Contributor

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 19, 2024
@jakebailey
Copy link
Member

Adding @sheetalkamat to verify but I've personally had issues debugging locally due to this assert firing when it was okay to do so, so I believe this is an okay change.

@sheetalkamat sheetalkamat merged commit 9f150e0 into microsoft:main Sep 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants