Expands CSS custom highlights API #1999
Closed
+108
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Why doesn't this get pulled in via some other types? (I am not personally knowledgeable about what has to be special cased or not) |
I don't know, may be because of the tests |
|
This exists already: TypeScript-DOM-lib-generator/baselines/dom.iterable.generated.d.ts Lines 151 to 152 in 7ca5f39 Seems the types are now available for ES5, but I don't think it's worth the effort, one should just use ES2015+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more methods to the
HighlightRegistryinterface according to the MDN docs.fixes #1698