stage_8 #84
Open
stage_8 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bwatada
commented
Oct 21, 2021
Test-NetStack.psm1
Outdated
| [String] $DpdkUser='', | ||
| [Parameter(Mandatory = $false)] | ||
| [String[]] $DpdkPortIps ='', | ||
| [Parameter(Mandatory = $false)] |
There was a problem hiding this comment.
I don't know what's going on here, tried fixing it both in editor and on the web and nothing seems to work. 👎
There was a problem hiding this comment.
There are a few other lines that look like this too, if anyone knows how to fix please help me
dcuomo
reviewed
Oct 21, 2021
smoon193
reviewed
Oct 25, 2021
helpers/tcp.psm1
Outdated
Comment on lines
76
to
79
| Sleep 30 | ||
|
|
||
| $ServerRecv = Receive-Job $ServerRecvCounter | ||
| $ClientSend = Receive-Job $ClientSendCounter |
There was a problem hiding this comment.
I think we wanted this sleep and to have the -Wait -AutoRemoveJob to avoid the issue where Stage 2 was hanging
smoon193
reviewed
Oct 25, 2021
helpers/tcp.psm1
Outdated
Comment on lines
94
to
95
| $ServerOutput = Receive-Job $ServerOutput | ||
| $ClientOutput = Receive-Job $ClientOutput |
There was a problem hiding this comment.
Same as above re: -Wait -AutoRemoveJob
msuddon
approved these changes
Nov 11, 2021
Test-NetStack.psm1
Outdated
| [Switch] $Experimental = $false, | ||
|
|
||
| [Parameter(Mandatory = $false, ParameterSetName = 'Experimental' , position = 5)] | ||
| [String] $DpdkUser='', |
There was a problem hiding this comment.
I thought we were doing away with the user here since it required a specific setup beforehand anyway?
There was a problem hiding this comment.
yes you're right, forgot to remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full background can be read here