Add Network Controller test to check for Network Adapter that matches RestInterface property #391
Conversation
| param() | ||
|
|
||
| Confirm-IsNetworkController | ||
| if ($Global:SdnDiagnostics.EnvironmentInfo.ClusterConfigType -ieq 'FailoverCluster') { |
There was a problem hiding this comment.
Isnt this too punishing?
We could just silently pass it, or we could have a field saying skipped/no applicable and let the execution continue.
There was a problem hiding this comment.
Shouldn't be too punishing as would require the user to directly invoke, which will just terminate and not process further. The test itself is only included in the Debug-NetworkController under the SF cluster type.
| $sdnHealthTest = New-SdnHealthTest | ||
| try { | ||
| $node = Get-SdnNetworkControllerNode -Name $env:COMPUTERNAME -ErrorAction Stop | ||
| $netAdapter = Get-NetAdapter -Name $node.RestInterface -ErrorAction Ignore |
There was a problem hiding this comment.
How does this work ? isnt it suppose to be executed on the network controller itself ?
There was a problem hiding this comment.
Get-SdnNetworkControllerNode is a wrapper around Get-NetworkController node that has fault tolerance if the SF cluster is down. -Name is used to return back the node that matches the local node, rather than all nodes in the cluster.
Description
Summary of changes:
Change type
Checklist: