Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use basic parsing #234

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dgosbell
Copy link

Changes proposed in this pull request:

  • Added the -UseBasicParsing parameter to all the calls to Invoke-WebRequest. This means that the user running commands that call this cmdlet does not need to have IE configured. This is useful if you are calling ReportingServicesTools commands from a SQL Agent job as the SQL Agent account may not have IE configured
  • Added try/catch to Out-RsRestCatalogItemId function to prevent errors when calling methods like Out-RestFolderContent and the folder contains items like linked reports that do not return a known extension

How to test this code:

  • Run Out-RestFolderContent on a folder containing a linked rdl report, it should report a warning, but run to completion
  • Run a script using a login that does not have IE configured (such as running via a SQL Agent job)

Has been tested on (remove any that don't apply):

  • Powershell 3 and above
  • Windows Server 2012 R2 and above
  • SQL Server 2017 and above

@msftclas
Copy link

msftclas commented Jun 13, 2019

CLA assistant check
All CLA requirements met.

@garethnewman
Copy link

Any chance of this being merged? Stopping me from using ReportingServicesTools for TFS release.

@jtarquino
Copy link
Member

The unit tests are not passing

https://ci.appveyor.com/project/jtarquino/reportingservicestools/builds/25245392/tests

For example
Failed to delete folder '/SUT_GetRsRestItemDataSource_3245bde6-acd5-40c7-8602-878239f34be7': Cannot bind parameter because parameter 'UseBasicParsing' is specified more than once. To provide multiple values to parameters that can accept multiple values, use the array syntax. For example, "-parameter value1,value2,value3"

@garethnewman
Copy link

I see the issue but I am not sure how to edit someone elses PR.

@jtarquino
Copy link
Member

I see the issue but I am not sure how to edit someone elses PR.

You will have to create your own fork and merge his changes into your fork and send a new PR (or going manual school and do copy and paste of the changes in your fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants