Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Part 1 of RippleCaryAdder workbook #794

Merged

Conversation

Parisha-Agrawal
Copy link
Contributor

Solutions for tasks 1.1 - tasks 1.3 of Ripple Carry Adder kata as per discussion in #542 (comment)

@ghost
Copy link

ghost commented Jun 19, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did a bit of cleanup (a couple of missing dots in the ends of sentences and whitespace seem not worth another round of review), and added a note to clarify that the workbook reasons about classical states - otherwise the reader could be confused about the relationship between the quantum states in the tasks and the classical bits in the solutions.

Thank you! Looking forward to the next parts! I'll be travelling next week so if you send a PR at that time, I'll get to it in July.

@tcNickolas tcNickolas merged commit 1865043 into microsoft:main Jun 21, 2022
@Parisha-Agrawal
Copy link
Contributor Author

Thanks @tcNickolas for quick turnaround on the PR. Looking forward to contribute the next parts. I am planning to send the next part in July for your review :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants