Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

update tests for basic gates #300

Merged
merged 6 commits into from
Mar 19, 2020
Merged

update tests for basic gates #300

merged 6 commits into from
Mar 19, 2020

Conversation

vivanwin
Copy link
Contributor

vivanwin and others added 3 commits March 14, 2020 21:24
* Unify various DumpDiffs into one, more parametrized method
* Clean up presentation of several tasks, add (hopefully) helpful messages
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should improve the user's debugging experience a lot, thank you for working on it!

I looked into how to unify the multiple versions of DumpDiff that use more-or-less the same logic, and by the time I convinced myself that my idea works it was pretty much implemented, so I went ahead and finished it. Passing the number of qubits and the state prep operation as parameters to the DumpDiff, combined with some wrappers for state prep gates, did the trick!

I also did a bit of cleanup on the tests we're running - for example, for task 2.1 we need to show the effect of the solutions the state we promised, not a general 2-qubit state, and the task 1.10 looked too heavy with controlled version of 2-qubit gate, after all. It looks like I did a pretty big revamp of your change, but it is mostly due to the unification of DumpDiff.

Thank you again for working on this!

@tcNickolas tcNickolas merged commit 57eaf0d into microsoft:master Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants