Use MSTest.Sdk (and migrate from VSTest to MTP) #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Few notes:
- You haven't enabled MSTest runner on all projects
- You will need to update the pipeline setup to use new arguments
- For now the new runner doesn't support coverlet through
coverlet.collectorso you can remove the deps on all projects. If owners are fine, we can switch to MS code coverage otherwise as part of the pipeline update we will need to move to coverlet dotnet tool
Youssef1313
force-pushed
the
mstest-cleanup
branch
from
2259590 to
8b16122
Compare
Youssef1313
changed the title
Youssef1313
force-pushed
the
mstest-cleanup
branch
from
8b16122 to
382b52a
Compare
Evangelink
approved these changes
Nov 27, 2024
|
@joem-msft Can I get a review on this PR please? |
Youssef1313
commented
Feb 12, 2025
Comment on lines
-43
to
-47
| - name: Test - Persistence | ||
| run: dotnet bin/Debug/Persistence.Tests/Persistence.Tests.dll | ||
|
|
||
| - name: Test - PAModel | ||
| run: dotnet bin/Debug/PAModelTests/PAModelTests.dll |
There was a problem hiding this comment.
@joem-msft FYI the assembly YamlValidator.Tests.dll wasn't run in CI. It's better to dotnet test on the solution rather than listing individual dlls.
There was a problem hiding this comment.
please do not start including the YamlValidator.Tests in the CI builds, as this project has been abandoned and not maintained.
Evangelink
approved these changes
Feb 12, 2025
| - name: Test - PAModel | ||
| run: dotnet bin/Debug/PAModelTests/PAModelTests.dll | ||
| - name: Test | ||
| run: dotnet test src/PASopa.sln --no-build |
There was a problem hiding this comment.
For maintainers: I would recommend to enable TRX report and Code Coverage.
There was a problem hiding this comment.
go ahead and enable if you would like.
Youssef1313
changed the title
mesganmsft
approved these changes
Feb 21, 2025
|
@mesganmsft Thanks for reviewing! Is this good to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730