-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling PowerApps MDA Image and Add Picture Control for Custom Pages with Test Engine Support #517
base: integration
Are you sure you want to change the base?
Conversation
@@ -32,7 +32,7 @@ public MDATypeMapping() | |||
typeMappings.Add("g", FormulaType.Guid); | |||
typeMappings.Add("m", FormulaType.Decimal); | |||
typeMappings.Add("v", FormulaType.UntypedObject); | |||
typeMappings.Add("i", FormulaType.Number); | |||
typeMappings.Add("i", FormulaType.String); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? in line 24 we have:
typeMappings.Add("s", FormulaType.String);
With this new line, we have the mapping "i" as well returns string.
Why the string type is mapped twice? (is that needed?) I see Number was twice before.
This comment comes with very limited understanding on how this map is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added mapping for the Image data type in Model Driven apps enables the conversion of image URLs to strings within the PowerFx engine. This enhancement ensures that control values can be effectively retrieved and set through PowerFx-based test cases. Currently, the PowerFx engine does not support the Image/HyperLink data type, and only the string data type is available as an alternative for these types.
Description
Enable PowerApps MDA Image and Add Picture controls for Custom Pages with Test Engine Support. This update involves creating a Power Apps MDA Custom page with all Image and Add Picture controls and developing a test plan to verify runtime and design time control properties. Additionally, code changes have been made to support asserting blank values for each control.
Work Items for this PR:
#423 - Image Control
#426 - Add Picture Control
Checklist