-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dashes (-) instead of 0 in the table #443
Conversation
@microsoft-github-policy-service agree |
This should be good to accept now 😅 |
@muiriswoulfe do you mind taking a look at this PR, and see if it's something you'd want in the action 🙂 |
I was away, but I'll take a look this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes. Overall, this looks good, but I've just left a few small comments.
Thanks @muiriswoulfe, I've done the updates requested 😊 |
It looks like there's token issues at the moment 😓 |
The issue is actually this one – it's a known issue with GitHub: openmainframeproject/feilong#367 I'll need to create a local copy to validate this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now run these changes locally via another PR, but I'd prefer if we merged your changes as you are the author not me and I don't intend to claim credit for this :)
One change you might have seen that the pipeline made is that it ran npm run build:package
. Since the pipeline can't run here, can you run that manually, commit the changes, and then I'll override the build and merge to main. Thanks!
@muiriswoulfe Done - Thanks |
Summary
Motivation
Show dashes (-) instead of 0 in the table
#442
Technical
Testing
Test Types
Unit Test Coverage
Other Test Details
Screenshots