OpenApiSchema refactor to remove recursive keywords #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pported in the latest JSON schema draft
…lization and deserialization
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng and
andrueastman
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -358,11 +348,9 @@ | |||
| Id = schema?.Id ?? Id; | |||
| Schema = schema?.Schema ?? Schema; | |||
| Comment = schema?.Comment ?? Comment; | |||
| Vocabulary = schema?.Vocabulary ?? Vocabulary; | |||
| Vocabulary = schema?.Vocabulary != null ? new Dictionary<string, bool>(schema.Vocabulary) : null; | |||
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor Warning
|
darrelmiller
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
recursiveRefandrecursiveAnchorkeywords from ourOpenApiSchemamodel as they're not supported in the latest JSON schema 2020-12 draftVocabularyproperty type in our model to represent a dictionary; cleans up the serialization and deserialization of said property