Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not default to an empty list if Security scheme is missing #1814

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix: Do not default to an empty list if Security scheme is missing #1814

merged 2 commits into from
Sep 4, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1797

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@MaggieKimani1 MaggieKimani1 merged commit 27c0e78 into vnext Sep 4, 2024
10 of 11 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-default-missing-properties-to-empty-list branch September 4, 2024 12:40
@MaggieKimani1 MaggieKimani1 mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@calebkiage calebkiage calebkiage approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not default to an empty list if a property is missing in the OpenAPI description
3 participants
@MaggieKimani1 @calebkiage @andrueastman