JsonSchema.NET Integration #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MaggieKimani1
commented
Jun 19, 2023
•
MaggieKimani1
commented
- Resolves integration of the JsonSchema.NET library for complete JSON schema support as part of implementing OpenAPI 3.1.
- Fixes:
- fixes Add OpenAPI 3.1 Support #795
- fixes ExclusiveMinimum and ExclusiveMaximum change from type boolean to type number #1271,
- fixes Enable upcasting from V2/V3 to 3.1 #1272,
- fixes Map nullable to null type #1273,
- fixes Add support for $schema, $id, $comment, $vocabulary, $dynamicRef, $dynamicAnchor, $recursiveAnchor, $recursiveRef #1274,
- fixes Support the core and validation keywords from the latest JSON schema specification (JSON Schema Specification Draft 2020-12) #1275
…-json-schema-library
…eserializer and cleaning up code
…t how to perform upcasting from OpenApiSchema to JsonSchema
…/use-json-node-for-parsing"
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
peombwa,
zengin and
baywet
as code owners
darrelmiller
reviewed
Nov 7, 2023
…' into mk/integrate-json-schema-library
src/Microsoft.OpenApi.Readers/V31/OpenApiSecurityRequirementDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Models/References/OpenApiHeaderReference.cs
Outdated
Show resolved
Hide resolved
| @@ -29,7 +29,7 @@ public abstract class ValidationRule | |||
| /// Class containing validation rule logic for <see cref="IOpenApiElement"/>. | |||
| /// </summary> | |||
| /// <typeparam name="T"></typeparam> | |||
| public class ValidationRule<T> : ValidationRule where T : IOpenApiElement | |||
| public class ValidationRule<T> : ValidationRule | |||
There was a problem hiding this comment.
Ugh. This is because JsonSchema doesn't implement this interface. Hmm, that seems like it is going to cause us problems.
darrelmiller
requested changes
Nov 13, 2023
This was referenced Nov 15, 2023
|
SonarCloud Quality Gate failed.
|
darrelmiller
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.