Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named dimension override for SD decoder #1472

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Named dimension override for SD decoder #1472

wants to merge 4 commits into from
+933 −910

Conversation

linnealovespie
Copy link
Collaborator

@linnealovespie linnealovespie commented Nov 8, 2024 •
edited
Loading

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@linnealovespie linnealovespie changed the title named dir override for enc/dec Named dimension override for SD decoder Nov 8, 2024
@linnealovespie linnealovespie marked this pull request as ready for review November 11, 2024 23:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
examples/stable_diffusion/sd_utils/ort.py
# ruff: noqa: TID252, T201


def update_cuda_config(config: Dict):

Check warning

Code scanning / lintrunner

PYLINT/W0621 Warning

Redefining name 'config' from outer scope (line 18) (redefined-outer-name)
See redefined-outer-name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linnealovespie @fdwr