Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Tweaks #914

Merged
merged 5 commits into from
Jan 6, 2025
Merged

VSCode Tweaks #914

merged 5 commits into from
Jan 6, 2025

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Jan 6, 2025

Pull Request

Title

Revert back to black VSCode extension.


Description

The pre-commit extension has issues in DevContainer environments where pre-commit is not installed on the host.

This PR reverts to the VSCode black formatting extension for interactive formatting and adds some additional attempts to make the isort equivalent that'd we'd otherwise get out of pre-commit to happen as well.

Note that these will be best effort for now. pre-commit formatting rules will still be authoritative.


Type of Change

  • 🛠️ Bug fix

Testing

Local edits.


Additional Notes (optional)

No guarantee that this is perfect unfortunately.


@bpkroth bpkroth added the ready for review Ready for review label Jan 6, 2025
@bpkroth bpkroth requested a review from a team as a code owner January 6, 2025 23:10
@motus motus enabled auto-merge (squash) January 6, 2025 23:12
@motus motus merged commit d7294fa into microsoft:main Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants