Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trial_runner_id column #907

Merged
merged 56 commits into from
Jan 6, 2025

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Jan 3, 2025

Pull Request

Title

Add trial_runner_id column to Trials table


Description


Type of Change

  • ✨ New feature

Testing

Manually


Additional Notes (optional)

To be merged after #906


@bpkroth bpkroth requested a review from a team as a code owner January 3, 2025 23:20
@bpkroth bpkroth added the ready for review Ready for review label Jan 4, 2025
@bpkroth bpkroth removed the ready for review Ready for review label Jan 4, 2025
@bpkroth bpkroth added ready for review Ready for review WIP Work in progress - do not merge yet and removed ready for review Ready for review labels Jan 4, 2025
@bpkroth bpkroth added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Jan 6, 2025
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a minor suggestion

mlos_bench/mlos_bench/storage/sql/schema.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/storage/sql/schema.py Outdated Show resolved Hide resolved
@bpkroth bpkroth enabled auto-merge (squash) January 6, 2025 19:33
@bpkroth bpkroth merged commit e20dff6 into microsoft:main Jan 6, 2025
15 checks passed
@bpkroth bpkroth deleted the add-trial-runner-id-column branch January 6, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants