Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json schema to the actual parameters of script_env #574

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update json schema to the actual parameters of script_env #574

merged 2 commits into from
Nov 1, 2023

Conversation

motus
Copy link
Member

@motus motus commented Nov 1, 2023

Remove unused parameters like shell_env_params_match and shell_env_params_mapping; add shell_env_params_rename

@motus motus requested a review from a team as a code owner November 1, 2023 20:04
@motus motus enabled auto-merge (squash) November 1, 2023 20:04
@motus motus added the ready for review Ready for review label Nov 1, 2023
bpkroth
bpkroth approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real config test case we can load?

@motus motus merged commit 62d279b into microsoft:main Nov 1, 2023
@motus motus deleted the sergiym/script_env/schema branch November 6, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motus @bpkroth