Skip to content

SaaS Environment + Azure Flex DB configuration service #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Nov 7, 2023
Merged

SaaS Environment + Azure Flex DB configuration service #520

merged 39 commits into from
Nov 7, 2023

Conversation

motus
Copy link
Member

@motus motus commented Sep 29, 2023

No description provided.

@motus motus added the WIP Work in progress - do not merge yet label Sep 29, 2023
@motus motus added the ready for review Ready for review label Sep 30, 2023
@motus
Copy link
Member Author

motus commented Oct 5, 2023 •
edited
Loading

Huge thanks @bpkroth for reviewing it! I'll keep it as draft for now - @eujing says that Azure API can return a flag indicating whether a config change requires a reboot, but I have not figured that stuff out yet. I'll implement it later and push it to this PR. Once it's here, I'll undraft (?) a PR 😄

UPDATE: I've added "restart on config change" feature. We might not need it for MySQL (if we implement MySQL server restart service so we don't have to reboot the whole VM), but it might still be necessary for other SaaS DBs, like PostgreSQL.

motus and others added 10 commits November 2, 2023 13:44
@motus
Merge branch 'main' into sergiym/service/flex
9c6620e
@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/environments/remote/saas-…
f80c9ec 
…env-subschema.json

Co-authored-by: Brian Kroth <[email protected]>
@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/environments/remote/saas-…
0233b9c 
…env-subschema.json

Co-authored-by: Brian Kroth <[email protected]>
@motus @bpkroth
Update mlos_bench/mlos_bench/environments/remote/saas_env.py
a553a31 
Co-authored-by: Brian Kroth <[email protected]>
@motus
Merge branch 'main' into sergiym/service/flex
20da2cb
@motus
make SaaS config service interface more cloud-agnostic. Allow both
db5f090 
reboot and restart options for .is_config_pending() method
@motus
fix the schema unit test for SaaS env
1c5fbd6
@motus
Merge branch 'main' into sergiym/service/flex
4ce3408
@motus
Merge branch 'main' into sergiym/service/flex
63e008d
@motus
Merge branch 'main' into sergiym/service/flex
ded1eaa
@motus motus mentioned this pull request Nov 6, 2023
Merged
motus added a commit that referenced this pull request Nov 6, 2023
@motus
Implement get_auth_headers() method in AzureAuthService (#584)
4a8e54a 
...and use it in `AzureVMService`. We will use it in #520 once it is
merged in.

Closes #581
bpkroth
bpkroth approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still don't love the use of vmName in this, but I think we can take it up later.

@motus motus merged commit 6b4cf3e into microsoft:main Nov 7, 2023
@motus motus deleted the sergiym/service/flex branch November 7, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motus @bpkroth