Skip to content

Commit

Permalink
CI fixups (#900)
Browse files Browse the repository at this point in the history
# Pull Request

## Title

Some fixups to account for new versions of matplotlib so that CI runs
again.

---

## Description

- Pulls in a new version of dabl with some fixes:
  dabl/dabl#353
- Adds an ignore for a seaborn issue:
  mwaskom/seaborn#3804
- Adjusts the python unit test debugger config to remove a deprecated
extension:
  https://code.visualstudio.com/docs/python/testing#_debug-tests

---

## Type of Change

- 🛠️ Bug fix

---
  • Loading branch information
bpkroth authored Dec 18, 2024
1 parent 0d43b2e commit 0a94138
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 4 deletions.
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"ms-python.pylint",
"ms-python.python",
"ms-python.vscode-pylance",
"ms-python.debugpy",
"ms-vsliveshare.vsliveshare",
"njpwerner.autodocstring",
"redhat.vscode-yaml",
Expand Down
1 change: 1 addition & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"ms-python.pylint",
"ms-python.python",
"ms-python.vscode-pylance",
"ms-python.debugpy",
"ms-vscode-remote.remote-containers",
"ms-vsliveshare.vsliveshare",
"njpwerner.autodocstring",
Expand Down
10 changes: 7 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
"version": "0.2.0",
"configurations": [
{
"name": "Debug Unit Test",
"type": "python",
"request": "test",
// See Also: https://code.visualstudio.com/docs/python/testing#_debug-tests
"name": "Python: Debug Tests",
"type": "debugpy",
"request": "launch",
"program": "${file}",
"purpose": ["debug-test"],
"console": "integratedTerminal",
"justMyCode": false,
"env": {
// When debugging tests, only run a single pytest worker instance.
Expand Down
1 change: 1 addition & 0 deletions conda-envs/mlos-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dependencies:
- ipykernel
- nb_conda_kernels
- matplotlib-base<3.9
- scikit-learn
- seaborn
- pandas
- pyarrow
Expand Down
10 changes: 10 additions & 0 deletions mlos_viz/mlos_viz/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ def ignore_plotter_warnings() -> None:
module="seaborn", # but actually comes from pandas
message="is_categorical_dtype is deprecated and will be removed in a future version.",
)
# See Also: https://github.com/mwaskom/seaborn/issues/3804
warnings.filterwarnings(
"ignore",
category=PendingDeprecationWarning,
module="seaborn", # but actually comes from matplotlib
message=(
"vert: bool will be deprecated in a future version. "
"Use orientation: {'vertical', 'horizontal'} instead."
),
)


def _add_groupby_desc_column(
Expand Down
2 changes: 1 addition & 1 deletion mlos_viz/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _get_long_desc_from_readme(base_url: str) -> dict:
version=VERSION,
install_requires=[
"mlos-bench==" + VERSION,
"dabl>=0.3.1",
"dabl>=0.3.2",
"matplotlib",
"seaborn>=0.12.2",
],
Expand Down

0 comments on commit 0a94138

Please sign in to comment.