Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [docs] add Oliver to CODEOWNERS #6247

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[ci] [docs] add Oliver to CODEOWNERS #6247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
# offer a reasonable automatic best-guess

# catch-all rule (this only gets matched if no rules below match)
* @guolinke @jameslamb @shiyu1994 @jmoralez
* @guolinke @jameslamb @shiyu1994 @jmoralez @borchero
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borchero this will automatically add you as a reviewer on every PR.

To be sure we set the right expectation...you do not need to review every PR! We require 1 approval from a maintainer to merge. In some situations, like more controversial changes or changes where particular maintainers have specialized knowledge, we sometimes ask for multiple approvals.

For example, for any non-trivial changes to distributed training, I'll probably ask for approvals from both @jmoralez (Dask knowledge) and one of @shiyu1994 and @guolinke (C++ and LightGBM internals knowledge).

43 changes: 7 additions & 36 deletions docs/FAQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,44 +11,15 @@ LightGBM FAQ

------

Critical Issues
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are included in this PR because I originally came to this page to add @borchero to the list of maintainers.

Explanation of the changes to these docs:

  • none of this applies to only "Critical" issues, so removed language like that
  • list of maintainers was seriously out-of-date
    • many of these people have not interacted with the repo in years
    • some of the notes about specialization were wrong (e.g. implying that I only work on R and Dask)
  • example questions don't add much information above what we ask for in the issue templates (https://github.com/microsoft/LightGBM/tree/master/.github/ISSUE_TEMPLATE)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm basically proposing changing this from "list of all maintainers" to "who you should @ if you need timely help".

===============
Please post questions, feature requests, and bug reports at https://github.com/microsoft/LightGBM/issues.

A **critical issue** could be a *crash*, *prediction error*, *nonsense output*, or something else requiring immediate attention.
This project is mostly maintained by volunteers, so please be patient.
If your request is time-sensitive or more than a month goes by without a response, please tag the maintainers below for help.

Please post such an issue in the `Microsoft/LightGBM repository <https://github.com/microsoft/LightGBM/issues>`__.

You may also ping a member of the core team according to the relevant area of expertise by mentioning them with the arabase (@) symbol:

- `@guolinke <https://github.com/guolinke>`__ **Guolin Ke** (C++ code / R-package / Python-package)
- `@chivee <https://github.com/chivee>`__ **Qiwei Ye** (C++ code / Python-package)
- `@shiyu1994 <https://github.com/shiyu1994>`__ **Yu Shi** (C++ code / Python-package)
- `@tongwu-msft` **Tong Wu** (C++ code / Python-package)
- `@hzy46 <https://github.com/hzy46>`__ **Zhiyuan He** (C++ code / Python-package)
- `@btrotta <https://github.com/btrotta>`__ **Belinda Trotta** (C++ code)
- `@Laurae2 <https://github.com/Laurae2>`__ **Damien Soukhavong** (R-package)
- `@jameslamb <https://github.com/jameslamb>`__ **James Lamb** (R-package / Dask-package)
- `@jmoralez <https://github.com/jmoralez>`__ **José Morales** (Dask-package)
- `@wxchan <https://github.com/wxchan>`__ **Wenxuan Chen** (Python-package)
- `@henry0312 <https://github.com/henry0312>`__ **Tsukasa Omoto** (Python-package)
- `@StrikerRUS <https://github.com/StrikerRUS>`__ **Nikita Titov** (Python-package)
- `@huanzhang12 <https://github.com/huanzhang12>`__ **Huan Zhang** (GPU support)

Please include as much of the following information as possible when submitting a critical issue:

- Is it reproducible on CLI (command line interface), R, and/or Python?

- Is it specific to a wrapper? (R or Python?)

- Is it specific to the compiler? (gcc or Clang version? MinGW or Visual Studio version?)

- Is it specific to your Operating System? (Windows? Linux? macOS?)

- Are you able to reproduce this issue with a simple case?

- Does the issue persist after removing all optimization flags and compiling LightGBM in debug mode?

When submitting issues, please keep in mind that this is largely a volunteer effort, and we may not be available 24/7 to provide support.
- `@guolinke <https://github.com/guolinke>`__ **Guolin Ke**
- `@shiyu1994 <https://github.com/shiyu1994>`__ **Yu Shi**
- `@jameslamb <https://github.com/jameslamb>`__ **James Lamb**
- `@jmoralez <https://github.com/jmoralez>`__ **José Morales**

--------------

Expand Down