Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] speed up valgrind job #6237

Merged
merged 5 commits into from
Dec 22, 2023
Merged

[ci] [R-package] speed up valgrind job #6237

merged 5 commits into from
Dec 22, 2023

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Dec 14, 2023

Proposes removing R-vignette-building from the valgrind CI job.

That job just installs the package and runs the unit tests:

RDvalgrind \
--no-readline \
--vanilla \
-d "valgrind --tool=memcheck --leak-check=full --track-origins=yes" \
-f testthat.R \
> ${ALL_LOGS_FILE} 2>&1 || exit -1

So the vignettes are totally unnecessary. Removing them removes the following sources of unnecessary work and therefore build time:

  • the need to install {knitr} and its many recursive dependencies
  • the extra compilation of lib_lightgbm done for vignette-building

@jameslamb
Copy link
Collaborator Author

jameslamb commented Dec 14, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/7204236057

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Dec 14, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/7204258936

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Dec 14, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/7204287590

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Dec 22, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/7296681094

Status: success ✔️.

@jameslamb jameslamb changed the title WIP: [ci] [R-package] speed up valgrind job [ci] [R-package] speed up valgrind job Dec 22, 2023
@jameslamb jameslamb marked this pull request as ready for review December 22, 2023 05:45
@jameslamb jameslamb merged commit 051eb22 into master Dec 22, 2023
42 checks passed
@jameslamb jameslamb deleted the ci/run-valgrind branch December 22, 2023 20:29
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants