-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] speed up valgrind job #6237
Conversation
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Proposes removing R-vignette-building from the
valgrind
CI job.That job just installs the package and runs the unit tests:
LightGBM/.ci/test_r_package_valgrind.sh
Lines 14 to 19 in 2dfb9a4
So the vignettes are totally unnecessary. Removing them removes the following sources of unnecessary work and therefore build time:
{knitr}
and its many recursive dependencieslib_lightgbm
done for vignette-building