-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] reduce redirects in docs links #6181
Conversation
@@ -27,7 +27,7 @@ We used 5 datasets to conduct our comparison experiments. Details of data are li | |||
+-----------+-----------------------+------------------------------------------------------------------------+-------------+----------+----------------------------------------------+ | |||
| MS LTR | Learning to rank | `link <https://www.microsoft.com/en-us/research/project/mslr/>`__ | 2,270,296 | 137 | {S1,S2,S3} as train set, {S5} as test set | | |||
+-----------+-----------------------+------------------------------------------------------------------------+-------------+----------+----------------------------------------------+ | |||
| Expo | Binary classification | `link <http://stat-computing.org/dataexpo/2009/>`__ | 11,000,000 | 700 | last 1,000,000 samples were used as test set | | |||
| Expo | Binary classification | `link <https://community.amstat.org/jointscsg-section/dataexpo/dataexpo2009>`__ | 11,000,000 | 700 | last 1,000,000 samples were used as test set | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Lines 116 to 118 in 694e41e
I just pushed a commit that fixed that: 7403cd1 Generated by making changes in python helpers/parameter_generator.py |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Follow-up to #6161.
Fixes some (but not all) of the warnings
linkchecker
raises about redirects in links from documentation. Most of these are harmless, just pages moving around within the same top-level domain.But one is a site that used to host a dataset and now hosts ... something about video games!
warnings addressed by this PR (click me)
How I tested this
Triggered
check-links
on this branch, with[http-redirected]
warnings fromlinkchecker
allowed, and saw the number of warnings go down from 32 to 14: https://github.com/microsoft/LightGBM/actions/runs/6793814320/job/18469251065