-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unnecessary exports of container-runtime package #23607
Merged
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fbb556c
Mark removed and deprecated
anthony-murphy ac64436
deprecations lints
anthony-murphy 984f5cb
add things back
anthony-murphy 3202af7
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 899ddc8
fix tagging
anthony-murphy ddd4188
revert some changes
anthony-murphy fbb55fa
add changeset
anthony-murphy dfe2e21
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy c72de80
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 1db84ee
Apply suggestions from code review
anthony-murphy 611033c
clean up lints
anthony-murphy 9474486
Merge branch 'main' into test/container-runtime-deprecations
anthony-murphy 4bae889
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 8e3ec4e
remove deprecation
anthony-murphy 876735f
mend
anthony-murphy 226ff03
mend
anthony-murphy ba5ca11
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 8be9540
Pr feedback
anthony-murphy ed43ff2
Update packages/runtime/container-runtime/src/containerRuntime.ts
anthony-murphy e277b55
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy afa4456
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
--- | ||
"@fluidframework/container-runtime": minor | ||
--- | ||
--- | ||
"section": deprecation | ||
--- | ||
|
||
Deprecate unnecessary exports of container-runtime package | ||
|
||
The following types in the `@fluidframework/container-runtime` are deprecated. These types are unnecessary for external users of this package. | ||
|
||
- currentDocumentVersionSchema | ||
- DeletedResponseHeaderKey | ||
- DocumentSchemaValueType | ||
- DocumentsSchemaController | ||
- GCFeatureMatrix | ||
- GCNodeType | ||
- GCVersion | ||
- IBlobManagerLoadInfo | ||
- ICancellableSummarizerController | ||
- ICancellationToken | ||
- IConnectableRuntime | ||
- IContainerRuntimeMetadata | ||
- ICreateContainerMetadata | ||
- IDocumentSchema | ||
- IDocumentSchemaChangeMessage | ||
- IDocumentSchemaCurrent | ||
- IDocumentSchemaFeatures | ||
- IGCMetadata | ||
- IGCStats | ||
- IMarkPhaseStats | ||
- IRefreshSummaryAckOptions | ||
- ISerializedElection | ||
- ISubmitSummaryOptions | ||
- ISummarizerInternalsProvider | ||
- ISummarizerRuntime | ||
- ISummaryCancellationToken | ||
- ISummaryMetadataMessage | ||
- ISweepPhaseStats | ||
- Summarizer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it help you to find/remove these if you put a keyword on these lines? Or... maybe you can just do
git revert
on this commit to start the removal branch?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run lint:fix
can remove them