-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed tune.report import for ray>=2 #1392
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Evotec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @drwillcharles , for the PR!
Hi @drwillcharles , could you check the test errors? Looks like the change will lead to test timeout issue. Thanks. |
It appears the test I have loosened the pydantic dependency and hope this solves the issue. |
OpenML is currently down so a lot of tests are getting connection errors. Will wait until this is back online before I resume development. From the tests that have run successfully, it appears there are still some environment issues to fix |
Why are these changes needed?
When using ray>=2, there is an import error for
tune.report
.I used the Ray migration guide to update this and use the new report function if the ray version is not 1.x .
I see that in the FLAML codebase there are already a few workarounds like this so I think I can do something similar without needing a full migration to Ray 2.x
Related issue number
Related to #874 - although I still think a full migration to Ray>=2 is needed in the future.
Checks