Skip to content

Commit

Permalink
Update push-test.yml (#591)
Browse files Browse the repository at this point in the history
* Update push-test.yml

When the upload-artifact action was updated to v4, the behavior of it changes such that you cannot create a unified "artifact" by having it add files to an existing artifact name. Instead, they all require a unique artifact name to be uploaded.

This should fix the current workflow build errors.

* Trying to fix the workflow to handle the name collision problem that starts in upload-artifact@v4

* Trying to get the cibuildwheel tool to work with the changes to AlmaLinux8 (why the heck is this docker image still shipping with an old gpg key anyway)

* Dynamic and Dynamic Labels were both trying to write to the  artifact
  • Loading branch information
daxpryce committed Oct 23, 2024
1 parent ef6c66f commit 708dbf1
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/disk-pq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: disk-pq
name: disk-pq-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/dynamic-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: dynamic
name: dynamic-labels-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/dynamic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: dynamic
name: dynamic-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/in-mem-no-pq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: in-memory-no-pq
name: in-memory-no-pq-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/in-mem-pq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: in-memory-pq
name: in-memory-pq-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: labels
name: labels-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/multi-sector-disk-pq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: upload data and bin
uses: actions/upload-artifact@v4
with:
name: multi-sector-disk-pq
name: multi-sector-disk-pq-${{matrix.os}}
path: |
./dist/**
./data/**
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
- name: Upload Metrics Logs
uses: actions/upload-artifact@v4
with:
name: metrics
name: metrics-${{matrix.os}}
path: |
./metrics/**
9 changes: 3 additions & 6 deletions .github/workflows/push-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,16 @@ jobs:
with:
fetch-depth: 1
submodules: true
- name: Build dispannpy dependency tree
- name: Build diskannpy dependency tree
run: |
pip install diskannpy pipdeptree
echo "dependencies" > dependencies_${{ matrix.os }}.txt
pipdeptree >> dependencies_${{ matrix.os }}.txt
- name: Archive dispannpy dependencies artifact
- name: Archive diskannpy dependencies artifact
uses: actions/upload-artifact@v4
with:
name: dependencies
name: dependencies_${{ matrix.os }}
path: |
dependencies_${{ matrix.os }}.txt
- name: DiskANN Build CLI Applications
uses: ./.github/actions/build
# python:
# name: DiskANN Build Python Wheel
# uses: ./.github/workflows/build-python.yml
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ test-command = "python -m unittest discover {project}/python/tests"

[tool.cibuildwheel.linux]
before-build = [
"rpm --import https://repo.almalinux.org/almalinux/RPM-GPG-KEY-AlmaLinux",
"dnf makecache --refresh",
"dnf upgrade -y almalinux-release",
"dnf install -y epel-release",
Expand Down

0 comments on commit 708dbf1

Please sign in to comment.