Update DirectXTexXbox.h #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'void*' to 'uint8_t*'
|
Having this as distinct PRs is a little problematic because they won't build due to the mismatch of the h and cpp. Can you combine the header and .cpp files? If not, I can approve them in bulk after local testing. |
|
Merging these changes into #538 |
walbourn
reviewed
Oct 24, 2024
| @@ -163,16 +163,16 @@ namespace Xbox | |||
|
|
|||
| HRESULT __cdecl CreateTexture( | |||
| _In_ ID3D12Device* d3dDevice, | |||
| _In_ const XboxImage& xbox, _Outptr_opt_ ID3D12Resource** ppResource, _Outptr_ void** grfxMemory); | |||
| _In_ const XboxImage& xbox, _Outptr_opt_ ID3D12Resource** ppResource, _Outptr_ const uint8_t** grfxMemory); | |||
There was a problem hiding this comment.
Note void* is actually the correct annotation for graphics memory. This is untyped memory in the video device range so could be really anything and maybe not byte accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'void*' to 'uint8_t*'