Use WARP from nuget by default #7427
Open
+177
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove special cases for warp - move the generic sounding "nuget.cmake" closer to where it is used, and rename to DownloadWarp.cmake - rearrange clang/test/CMakeLists.txt to make logic clearer about what is / isn't executed when using a multi-config generator
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
reviewed
May 5, 2025
alsepkow
reviewed
May 5, 2025
alsepkow
reviewed
May 5, 2025
alsepkow
reviewed
May 5, 2025
alsepkow
reviewed
May 5, 2025
alsepkow
reviewed
May 13, 2025
alsepkow
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using WARP from nuget was something that had to be opted in to. This change makes it the default behvior.
This allows some simplifications. The nuget package is installed at configure time. If the user wants to override the nuget installation behavior then they can pass in extra parameters, rather than having an alternative mechanism for describing which package to use.
The actual DLL to load is specified through a TAEF parameter and specifies the full path to the DLL.